Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: rollback vetting historical stateproof blocks #5830

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

algorandskiy
Copy link
Contributor

Summary

  1. Rolled back the Feature: Catchup Eval Stake Exception Round Handling #5795
  2. Changed the stakeDiffusionFactor to 1 from 5.

Test Plan

  1. Existing unit tests
  2. TODO: Manual catchup on the affected range

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (90b10d2) 55.81% compared to head (995d179) 55.79%.

Files Patch % Lines
ledger/eval/eval.go 9.52% 18 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5830      +/-   ##
==========================================
- Coverage   55.81%   55.79%   -0.03%     
==========================================
  Files         476      476              
  Lines       67138    67148      +10     
==========================================
- Hits        37476    37468       -8     
- Misses      27141    27157      +16     
- Partials     2521     2523       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval - assumes catchup passes and we resolve discussion on whether to in fact keep the new test.

@algorandskiy algorandskiy merged commit 5d047a4 into algorand:master Nov 16, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants