WIP: network: fix p2p received_{bytes, messages}_TX metrics #6144
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6144 +/- ##
==========================================
- Coverage 56.25% 56.25% -0.01%
==========================================
Files 494 494
Lines 69946 69948 +2
==========================================
+ Hits 39350 39351 +1
- Misses 27919 27920 +1
Partials 2677 2677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-more-metrics
branch
2 times, most recently
from
8586d2e
to
0bdaf73
Compare
algorandskiy
changed the title
algorandskiy
force-pushed
the
pavel/p2p-more-metrics
branch
from
0bdaf73
to
8fec6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new algod_peer_p2p_broadcast_dropped_total metric to evaluate drops.
Test Plan
Existing tests