eval: do not disassemble failed app transaction #6170
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
changed the title
jannotti
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Seems right to me. The disassembly in algod shouldn't be needed any more. I think the ecosystem has moved on to using source maps. A caller could disassemble on their own to find the error context.
If we agree this is permanent, we should remove pcDetails func entirely.
algorandskiy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## experimental-tweaks #6170 +/- ##
=======================================================
- Coverage 56.31% 56.25% -0.06%
=======================================================
Files 494 494
Lines 69964 69964
=======================================================
- Hits 39399 39360 -39
- Misses 27893 27919 +26
- Partials 2672 2685 +13 ☔ View full report in Codecov by Sentry. |
algorandskiy
merged commit 6186582
into
algorand:experimental-tweaks
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disassembling failed app transactions looks too expensive. Disabled for now.