Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Fix errors showing up w/ golanci-lint #1358

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

Eric-Warehime
Copy link
Contributor

Summary

Corrects most of the errors showing up when I merge the 2.15.0 release changes (including golangci-lint) into develop.

  • misspellings
  • unhandled errors -- I've chosen to acknowledge those instead of handle them explicitly
  • import order

@Eric-Warehime Eric-Warehime added tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead Bug-Fix Skip-Release-Notes Reserved for PRs which do not need to be included in Release Notes labels Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1358 (9df33cb) into develop (d672efe) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff            @@
##           develop    #1358   +/-   ##
========================================
  Coverage    60.71%   60.71%           
========================================
  Files           76       76           
  Lines        10909    10909           
========================================
  Hits          6623     6623           
  Misses        3699     3699           
  Partials       587      587           
Impacted Files Coverage Δ
conduit/errors.go 0.00% <0.00%> (ø)
conduit/plugins/exporters/postgresql/util/prune.go 75.00% <ø> (ø)
conduit/plugins/importers/algod/algod_importer.go 78.02% <ø> (ø)
conduit/plugins/importers/filereader/filereader.go 89.06% <ø> (ø)
...ugins/processors/blockprocessor/block_processor.go 66.39% <ø> (ø)
...it/plugins/processors/blockprocessor/initialize.go 63.88% <ø> (ø)
...lugins/processors/filterprocessor/fields/filter.go 80.00% <ø> (ø)
...gins/processors/filterprocessor/fields/searcher.go 82.69% <0.00%> (ø)
...ins/processors/filterprocessor/filter_processor.go 82.66% <ø> (ø)
util/util.go 76.92% <ø> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Eric-Warehime Eric-Warehime removed tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead Bug-Fix labels Nov 30, 2022
@Eric-Warehime Eric-Warehime merged commit 9af98d3 into algorand:develop Nov 30, 2022
@Eric-Warehime Eric-Warehime deleted the golanci-lint branch November 30, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Release-Notes Reserved for PRs which do not need to be included in Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants