-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: more integration test refactoring #1424
Conversation
This reverts commit ea0e6f0.
Codecov Report
@@ Coverage Diff @@
## develop #1424 +/- ##
===========================================
- Coverage 65.10% 65.04% -0.06%
===========================================
Files 79 79
Lines 11276 11276
===========================================
- Hits 7341 7335 -6
- Misses 3370 3374 +4
- Partials 565 567 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. In the long term, I think it should be made easy to onboard someone into creating the *.vb fixtures and writing these e2e tests, and I understand that there is design doc that is being planned to address this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
remove proc(&rpcs.EncodedBlockCert{Block: block}) from integration tests.