Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: more integration test refactoring #1424

Merged
merged 14 commits into from
Jan 23, 2023
Merged

Conversation

shiqizng
Copy link
Contributor

remove proc(&rpcs.EncodedBlockCert{Block: block}) from integration tests.

@shiqizng shiqizng self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1424 (3dc5d19) into develop (fe96f24) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1424      +/-   ##
===========================================
- Coverage    65.10%   65.04%   -0.06%     
===========================================
  Files           79       79              
  Lines        11276    11276              
===========================================
- Hits          7341     7335       -6     
- Misses        3370     3374       +4     
- Partials       565      567       +2     
Impacted Files Coverage Δ
accounting/eval_preload.go 57.75% <0.00%> (-1.61%) ⬇️
idb/postgres/postgres.go 65.21% <0.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiqizng shiqizng added the Enhancement New feature or request label Jan 19, 2023
@shiqizng shiqizng changed the title more integration test refactoring enhancement: more integration test refactoring Jan 19, 2023
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. In the long term, I think it should be made easy to onboard someone into creating the *.vb fixtures and writing these e2e tests, and I understand that there is design doc that is being planned to address this issue.

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiqizng shiqizng merged commit 63bdb86 into develop Jan 23, 2023
@shiqizng shiqizng deleted the shiqi/inttests2 branch January 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Team Lamprey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants