Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: E2e sync mode test #1431

Merged
merged 31 commits into from
Feb 15, 2023

Conversation

Eric-Warehime
Copy link
Contributor

A working e2e test using the sync mode.

It uses my personal branch of go-algorand as the submodule since the PR for sync mode has not been merged yet.
I also hard coded a bunch of things, you can't run the regular indexer in parallel to the sync mode, and this is based off of the PR which does nothing with the delta as of right now.

@Eric-Warehime Eric-Warehime added the Enhancement New feature or request label Jan 21, 2023
@Eric-Warehime
Copy link
Contributor Author

@AlgoStephenAkiki FYI

@winder
Copy link
Contributor

winder commented Jan 23, 2023

Could you rebase on develop? I tried to push the SDK upgrade separately to cleanup the diffs

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1431 (8afecce) into develop (ddcdc77) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1431      +/-   ##
===========================================
- Coverage    65.31%   65.26%   -0.06%     
===========================================
  Files           83       83              
  Lines        11452    11452              
===========================================
- Hits          7480     7474       -6     
- Misses        3402     3406       +4     
- Partials       570      572       +2     
Impacted Files Coverage Δ
fetcher/fetcher.go 62.71% <0.00%> (-1.28%) ⬇️
idb/postgres/postgres.go 65.44% <0.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines +11 to +13
processors=[
processors.BlockEvaluator(),
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need the block evaluator with this importer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eric-Warehime Eric-Warehime changed the title draft: E2e sync mode test e2e-test: E2e sync mode test Feb 13, 2023
wget https://raw.githubusercontent.com/algorand/go-algorand/rel/stable/cmd/updater/update.sh && chmod 744 update.sh
./update.sh -i -c nightly -n -d ./ -p /usr/local/go/bin
export GOPATH=/usr/local/go/
- run: make e2e-nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the dockerfile used for e2e-nightly be updated, too? it also runs this wget command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually specified the GOPATH in circleCI because it defaults to /home/circleci/.go_workspace:/usr/local/go_workspace so things break when you try to install binaries there.

In docker we don't have that problem, it's just a single directory, so we don't need to do special stuff there.

@Eric-Warehime Eric-Warehime merged commit cb4581c into algorand:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants