-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e-test: E2e sync mode test #1431
e2e-test: E2e sync mode test #1431
Conversation
Co-authored-by: Eric Warehime <[email protected]>
Could you rebase on develop? I tried to push the SDK upgrade separately to cleanup the diffs |
Codecov Report
@@ Coverage Diff @@
## develop #1431 +/- ##
===========================================
- Coverage 65.31% 65.26% -0.06%
===========================================
Files 83 83
Lines 11452 11452
===========================================
- Hits 7480 7474 -6
- Misses 3402 3406 +4
- Partials 570 572 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
processors=[ | ||
processors.BlockEvaluator(), | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need the block evaluator with this importer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do for now since the importer does nothing with the retrieved delta https://github.com/algorand/indexer/blob/develop/conduit/plugins/importers/algodfollower/algodfollower_importer.go#L156
wget https://raw.githubusercontent.com/algorand/go-algorand/rel/stable/cmd/updater/update.sh && chmod 744 update.sh | ||
./update.sh -i -c nightly -n -d ./ -p /usr/local/go/bin | ||
export GOPATH=/usr/local/go/ | ||
- run: make e2e-nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the dockerfile used for e2e-nightly be updated, too? it also runs this wget command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually specified the GOPATH
in circleCI because it defaults to /home/circleci/.go_workspace:/usr/local/go_workspace
so things break when you try to install binaries there.
In docker we don't have that problem, it's just a single directory, so we don't need to do special stuff there.
A working e2e test using the sync mode.
It uses my personal branch of go-algorand as the submodule since the PR for sync mode has not been merged yet.
I also hard coded a bunch of things, you can't run the regular indexer in parallel to the sync mode, and this is based off of the PR which does nothing with the delta as of right now.