Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algodfollower: Fix genesis file parsing and error handling. #1447

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jan 30, 2023

Summary

When the algodfollower plugin forked the algod plugin it was out of date (missing the LenientDecode change). There was another bug fix during development which didn't make it into the algodfollower plugin.

@winder winder added the Bug-Fix label Jan 30, 2023
@winder winder self-assigned this Jan 30, 2023
@winder winder changed the title Fix genesis file parsing and error handling. algodfollower: Fix genesis file parsing and error handling. Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1447 (b81eb06) into develop (451d4b3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1447      +/-   ##
===========================================
+ Coverage    65.13%   65.14%   +0.01%     
===========================================
  Files           80       80              
  Lines        11376    11380       +4     
===========================================
+ Hits          7410     7414       +4     
  Misses        3394     3394              
  Partials       572      572              
Impacted Files Coverage Δ
.../importers/algodfollower/algodfollower_importer.go 74.25% <100.00%> (+1.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review January 31, 2023 14:35
@winder winder merged commit 92991d8 into algorand:develop Jan 31, 2023
@winder winder deleted the will/fix-follow-genesis branch January 31, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants