Bug Fix: Supported Disabled option #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1333 Supports the disabled value for the PruneConfigurations "Interval" config
AlgoStephenAkiki
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1448 +/- ##
===========================================
- Coverage 65.15% 65.15% -0.01%
===========================================
Files 80 80
Lines 11377 11384 +7
===========================================
+ Hits 7413 7417 +4
- Misses 3393 3395 +2
- Partials 571 572 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
approved these changes
Jan 31, 2023
Comment on lines
+64
to
+68
| // A helpful warning to say that despite a number of rounds being above 0 | ||
| // data pruning isn't going to occur | ||
| if p.config.Rounds > 0 { | ||
| p.logger.Warnf("DeleteLoop(): Round value was above 0 (%d) but interval was disabled. No data pruning will occur.", p.config.Rounds) | ||
| } |
Eric-Warehime
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1333
Supports the disabled value for the PruneConfigurations "Interval" config