-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conduit: update plugin interface types #1473
Conversation
I will rebase when #1468 is merged. |
Codecov Report
@@ Coverage Diff @@
## develop #1473 +/- ##
===========================================
- Coverage 65.61% 65.40% -0.22%
===========================================
Files 82 82
Lines 11384 11443 +59
===========================================
+ Hits 7470 7484 +14
- Misses 3353 3389 +36
- Partials 561 570 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -69,38 +67,46 @@ func (blkData *BlockData) UpdateFromEncodedBlockCertificate(input *rpcs.EncodedB | |||
|
|||
// MakeBlockDataFromEncodedBlockCertificate makes BlockData from rpcs.EncodedBlockCert | |||
func MakeBlockDataFromEncodedBlockCertificate(input *rpcs.EncodedBlockCert) BlockData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get rid of this now? What else needs the encoded block cert converted after this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block_processor still uses this. we can remove it when removing the block_processor which is one of the last steps.
resolves #1438