Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit: update plugin interface types #1473

Merged
merged 32 commits into from
Feb 21, 2023
Merged

conduit: update plugin interface types #1473

merged 32 commits into from
Feb 21, 2023

Conversation

shiqizng
Copy link
Contributor

resolves #1438

@shiqizng
Copy link
Contributor Author

I will rebase when #1468 is merged.

@shiqizng shiqizng self-assigned this Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1473 (1b1819f) into develop (caddb25) will decrease coverage by 0.22%.
The diff coverage is 57.02%.

@@             Coverage Diff             @@
##           develop    #1473      +/-   ##
===========================================
- Coverage    65.61%   65.40%   -0.22%     
===========================================
  Files           82       82              
  Lines        11384    11443      +59     
===========================================
+ Hits          7470     7484      +14     
- Misses        3353     3389      +36     
- Partials       561      570       +9     
Impacted Files Coverage Δ
...plugins/processors/filterprocessor/gen/generate.go 36.92% <0.00%> (ø)
...filterprocessor/fields/generated_signed_txn_map.go 17.08% <18.75%> (ø)
...ugins/processors/blockprocessor/block_processor.go 70.83% <40.00%> (-3.07%) ⬇️
conduit/init_provider.go 55.55% <50.00%> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 78.75% <60.00%> (+0.72%) ⬆️
helpers/helpers.go 34.69% <61.70%> (+1.36%) ⬆️
data/block_export_data.go 80.00% <78.26%> (-2.70%) ⬇️
conduit/pipeline/pipeline.go 64.32% <100.00%> (ø)
conduit/plugins/importers/algod/algod_importer.go 77.96% <100.00%> (ø)
...lugins/processors/filterprocessor/fields/filter.go 80.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shiqizng shiqizng added Enhancement New feature or request Team Lamprey labels Feb 17, 2023
@shiqizng shiqizng marked this pull request as draft February 17, 2023 14:24
@@ -69,38 +67,46 @@ func (blkData *BlockData) UpdateFromEncodedBlockCertificate(input *rpcs.EncodedB

// MakeBlockDataFromEncodedBlockCertificate makes BlockData from rpcs.EncodedBlockCert
func MakeBlockDataFromEncodedBlockCertificate(input *rpcs.EncodedBlockCert) BlockData {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of this now? What else needs the encoded block cert converted after this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block_processor still uses this. we can remove it when removing the block_processor which is one of the last steps.

@shiqizng shiqizng marked this pull request as ready for review February 21, 2023 15:02
@Eric-Warehime Eric-Warehime merged commit b94e4f1 into develop Feb 21, 2023
@shiqizng shiqizng deleted the shiqi/plugins branch March 1, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Team Lamprey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licensing - update conduit plugin interface types
2 participants