Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Run conduit-docs directly. #1477

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Feb 17, 2023

Summary

Avoid the requirement to install conduit-docs and have $GOPATH/bin on your $PATH by running conduit-docs directly.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1477 (fcdf33e) into develop (789fa06) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1477   +/-   ##
========================================
  Coverage    65.59%   65.59%           
========================================
  Files           82       82           
  Lines        11384    11384           
========================================
  Hits          7467     7467           
  Misses        3355     3355           
  Partials       562      562           
Impacted Files Coverage Δ
fetcher/fetcher.go 62.71% <0.00%> (-1.28%) ⬇️
idb/postgres/postgres.go 65.63% <0.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM you need to resolve merge conflict though

@winder winder marked this pull request as ready for review February 17, 2023 21:15
@winder winder changed the title Run conduit-docs directly. docs: Run conduit-docs directly. Feb 17, 2023
@winder winder added the Enhancement New feature or request label Feb 17, 2023
@winder winder merged commit caddb25 into algorand:develop Feb 18, 2023
@winder winder deleted the will/reduce-path-dependency branch February 18, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants