Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algod: Importer Plugin Update #1478

Merged
merged 32 commits into from
Feb 22, 2023

Conversation

Eric-Warehime
Copy link
Contributor

@Eric-Warehime Eric-Warehime commented Feb 17, 2023

Summary

Reverts a bunch of stuff that I was trying around retries which actually made performance worse.

Also, updates the algod importer to actually use deltas when in follower mode.

Test Plan

Perf tests run against this:

round runtime_duration_s runtime_duration
1000000 5936 1h38m56s
2000000 13183 3h39m43s
3000000 18963 5h16m3s
4000000 27924 7h45m24s
5000000 34611 9h36m51s
6000000 41275 11h27m55s
7000000 49959 13h52m39s
8000000 57025 15h50m25s
9000000 65416 18h10m16s
10000000 72542 20h9m2s
11000000 79675 22h7m55s
12000000 91056 25h17m36s
13000000 100850 28h0m50s
14000000 108774 30h12m54s
15000000 117788 32h43m8s
16000000 126446 35h7m26s
17000000 136629 37h57m9s
18000000 148541 41h15m41s
19000000 162514 45h8m34s
20000000 174521 48h28m41s
21000000 184772 51h19m32s
22000000 195869 54h24m29s
23000000 204678 56h51m18s
24000000 213874 59h24m34s
25000000 224335 62h18m55s
26000000 234697 65h11m37s
27000000 242708 67h25m8s

@Eric-Warehime Eric-Warehime added the Enhancement New feature or request label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1478 (17120a0) into develop (b94e4f1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1478      +/-   ##
===========================================
+ Coverage    65.40%   65.41%   +0.01%     
===========================================
  Files           82       82              
  Lines        11443    11447       +4     
===========================================
+ Hits          7484     7488       +4     
  Misses        3389     3389              
  Partials       570      570              
Impacted Files Coverage Δ
conduit/plugins/importers/algod/algod_importer.go 78.68% <100.00%> (+0.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Eric-Warehime Eric-Warehime marked this pull request as ready for review February 21, 2023 20:25
@Eric-Warehime Eric-Warehime merged commit e6f1c07 into algorand:develop Feb 22, 2023
@Eric-Warehime Eric-Warehime deleted the plugin-update branch February 22, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants