importer: rewrite make integration #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiqizng
force-pushed
the
shiqi/importer
branch
from
91ae9d8
to
8743741
Compare
shiqizng
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1485 +/- ##
===========================================
+ Coverage 65.45% 67.05% +1.59%
===========================================
Files 82 80 -2
Lines 11470 11278 -192
===========================================
+ Hits 7508 7562 +54
+ Misses 3391 3145 -246
Partials 571 571
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
changed the title
shiqizng
commented
Feb 28, 2023
| return resp, body | ||
| } | ||
|
|
||
| // recreate tests from common.sh/create_delete_tests() |
There was a problem hiding this comment.
these tests are replicating those in common.sh/create_delete_tests(). Given how tedious it is to create the vb files, not all tests are replicated. Let me know if you see cases that should be covered.
Eric-Warehime
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
The one test which might be useful for backwards compatibility reasons is https://github.com/algorand/indexer/blob/develop/test/common.sh#L409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite make integration tests as handler tests and remove importer code and reference.