-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding: Better support for address encodings. #1531
encoding: Better support for address encodings. #1531
Conversation
6840b46
to
47c3051
Compare
Codecov Report
@@ Coverage Diff @@
## hotfix/2.15.4 #1531 +/- ##
================================================
Coverage ? 65.24%
================================================
Files ? 52
Lines ? 8375
Branches ? 0
================================================
Hits ? 5464
Misses ? 2436
Partials ? 475
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine but do we need to cherry-pick fixes to this hotfix branch everytime? I'm not familiar with this dual branch system.
edit: Oh is this the legacy indexer? I guess that makes more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good. I'm starting an indexer deployment to verify that it works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was correctly copied
Confirmed regression fix with mainnet data. Scenario: Initialize postgres DB using Conduit master branch and a mainnet follower node. Indexer running the current tip of master: 1c79c90 reproduces the encoding error $ curl localhost:10000/v2/blocks/20215865?pretty
{
"message": "error while looking up block for round '20215865': json decode error [pos 641]: failed to decode address 2GpQYYQK6VSxGFumcF/wZ4OLnJDJTASMIG5VL/AyU4k= to base 32"
} This PR applied to the $ curl -s localhost:10000/v2/blocks/20215865?pretty|grep part
"participation-updates": {
"expired-participation-accounts": [
|
Summary
There is a bug in the newer version of Indexer used by Conduit which caused addresses to be encoded differently. This PR makes the decoding more lenient to allow for the different encodings.
Test Plan
New unit test.