Tests: Group resource shared accounts handling #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s properly when group resource sharing occurs.
gmalouf
added
tech debt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
+ Coverage 68.42% 68.45% +0.02%
==========================================
Files 37 37
Lines 7434 7434
==========================================
+ Hits 5087 5089 +2
+ Misses 1917 1915 -2
Partials 430 430 ☔ View full report in Codecov by Sentry. |
jasonpaulos
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce test ensuring indexer handles indexing into shared addresses properly when group resource sharing occurs.
Test Plan
Updated test, ran both before and after patch in place (fails when patch removed, succeeds in current state).