update indexer reviewdog configuration

.github/workflows/reviewdog.yml

@@ -10,21 +10,21 @@ jobs:
         uses: actions/[email protected]
         with:
           fetch-depth: 0 # required for new-from-rev option in .golangci.yml
-      - name: Install libraries
-        run: sudo apt-get -y -q install libboost-math-dev
       - name: Install specific golang
         uses: actions/[email protected]
         with:
           go-version: '1.20.14'
       - name: reviewdog-golangci-lint
         uses: reviewdog/[email protected]
         with:
+          go_version_file: go.mod
           golangci_lint_version: "v1.53.2"
           golangci_lint_flags: "-c .golangci.yml --allow-parallel-runners"
-          reporter: "github-pr-review"
+          reporter: "github-pr-check"
           tool_name: "Lint Errors"
           level: "error"
           fail_on_error: true
+          filter_mode: "nofilter"
   # Non-Blocking Warnings Section
   reviewdog-warnings:
     runs-on: ubuntu-latest
@@ -33,50 +33,18 @@ jobs:
         uses: actions/[email protected]
         with:
           fetch-depth: 0 # required for new-from-rev option in .golangci.yml
-      - name: Install libraries
-        run: sudo apt-get -y -q install libboost-math-dev
       - name: Install specific golang
         uses: actions/[email protected]
         with:
           go-version: '1.20.14'
-      - name: Add bin to PATH
-        run: |
-          echo "$GITHUB_WORKSPACE/bin" >> $GITHUB_PATH
-          echo "$RUNNER_WORKSPACE/$(basename $GITHUB_REPOSITORY)/bin" >> $GITHUB_PATH
-      - name: Create folders for golangci-lint
-        run: mkdir -p cicdtmp/golangci-lint
-      - name: Check if custom golangci-lint is already built
-        id: cache-golangci-lint
-        uses: actions/[email protected]
+      - name: reviewdog-golangci-lint
+        uses: reviewdog/[email protected]
         with:
-          path: cicdtmp/golangci-lint/golangci-lint-cgo
-          key: cicd-golangci-lint-cgo-v0.0.2
-
-      - name: Build custom golangci-lint with CGO_ENABLED
-        if: steps.cache-golangci-lint.outputs.cache-hit != 'true'
-        run: |
-          cd cicdtmp/golangci-lint
-          git clone https://github.com/golangci/golangci-lint.git .
-          git checkout tags/v1.53.2
-          CGO_ENABLED=true go build -trimpath -o golangci-lint-cgo ./cmd/golangci-lint
-          ./golangci-lint-cgo --version
-          cd ../../
-      - name: Install reviewdog
-        run: |
-          curl -sfL https://raw.githubusercontent.com/reviewdog/reviewdog/v0.14.1/install.sh | sh -s
-          reviewdog --version
-      - name: Run golangci-lint with reviewdog
-        env:
-          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: >
-          ./cicdtmp/golangci-lint/golangci-lint-cgo run
-          --out-format line-number
-          -c .golangci-warnings.yml
-          --allow-parallel-runners
-          | reviewdog
-          -f=golangci-lint
-          -name="Lint Warnings"
-          -reporter=github-check
-          -filter-mode=added
-          -fail-on-error=false
-          -level=warning
+          go_version_file: go.mod
+          golangci_lint_version: "v1.53.2"
+          golangci_lint_flags: "-c .golangci-warnings.yml --allow-parallel-runners"
+          reporter: "github-pr-check"
+          tool_name: "Lint Warnings"
+          level: "warning"
+          fail_on_error: false
+          filter_mode: "added"

config/datadir.go

@@ -2,7 +2,6 @@ package config
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strings"
@@ -29,7 +28,7 @@ func algodStat(netpath string) (lastmod time.Time, err error) {
 func AlgodArgsForDataDir(datadir string) (netAddr string, token string, lastmod time.Time, err error) {
 	netpath, tokenpath := algodPaths(datadir)
 	var netaddrbytes []byte
-	netaddrbytes, err = ioutil.ReadFile(netpath)
+	netaddrbytes, err = os.ReadFile(netpath)
 	if err != nil {
 		err = fmt.Errorf("%s: %v", netpath, err)
 		return
@@ -39,7 +38,7 @@ func AlgodArgsForDataDir(datadir string) (netAddr string, token string, lastmod
 		netAddr = "http://" + netAddr
 	}
 
-	tokenBytes, err := ioutil.ReadFile(tokenpath)
+	tokenBytes, err := os.ReadFile(tokenpath)
 	if err != nil {
 		err = fmt.Errorf("%s: %v", tokenpath, err)
 		return

util/test/account_testutil.go

@@ -1,9 +1,9 @@
 package test
 
 import (
+	"crypto/rand"
 	"crypto/sha512"
 	"fmt"
-	"math/rand"
 
 	"github.com/algorand/indexer/v3/util"
 
@@ -58,7 +58,10 @@ func DecodeAddressOrPanic(addr string) sdk.Address {
 // This is necessary to ensure the hash of any two txns used in tests are never the same.
 func ArbitraryString() []byte {
 	arb := make([]byte, config.MaxTxnNoteBytes)
-	rand.Read(arb)
+	_, err := rand.Read(arb)
+	if err != nil {
+		panic("rand.Read error")
+	}
 	return arb
 }
 

util/util.go

@@ -4,7 +4,6 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strings"
@@ -233,7 +232,7 @@ func ReadGenesis(in io.Reader) (sdk.Genesis, error) {
 	if in == nil {
 		return sdk.Genesis{}, fmt.Errorf("ReadGenesis() err: reader is nil")
 	}
-	gbytes, err := ioutil.ReadAll(in)
+	gbytes, err := io.ReadAll(in)
 	if err != nil {
 		return sdk.Genesis{}, fmt.Errorf("ReadGenesis() err: %w", err)
 	}