Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in import state #717

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Cleanup in import state #717

merged 2 commits into from
Oct 8, 2021

Conversation

tolikzinovyev
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #717 (66ff5ff) into develop (b382d94) will increase coverage by 1.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #717      +/-   ##
===========================================
+ Coverage    53.10%   54.26%   +1.16%     
===========================================
  Files           23       23              
  Lines         3642     3750     +108     
===========================================
+ Hits          1934     2035     +101     
- Misses        1450     1455       +5     
- Partials       258      260       +2     
Impacted Files Coverage Δ
idb/postgres/postgres.go 46.46% <100.00%> (+0.01%) ⬆️
idb/postgres/internal/writer/writer.go 86.62% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b382d94...66ff5ff. Read the comment docs.

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this prevent us from showing the upgrade error message if people try to run the new version with a version < 2.7.x?

@tolikzinovyev
Copy link
Contributor Author

You are right, I restored MigrationState.

@tolikzinovyev tolikzinovyev changed the title Cleanup in import and migration state Cleanup in import state Oct 6, 2021
@tolikzinovyev tolikzinovyev merged commit 18004b0 into develop Oct 8, 2021
@tolikzinovyev tolikzinovyev deleted the tolik/types-cleanup branch October 8, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants