Add additional encoding tests. #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiqizng
reviewed
Jan 27, 2022
| require.NoError(t, err) | ||
|
|
||
| err = db.AddBlock(&block) | ||
| require.NoError(t, err, "failed to commit") |
There was a problem hiding this comment.
nit: is msg needed for noError?
shiqizng
approved these changes
Jan 28, 2022
AlgoStephenAkiki
approved these changes
Jan 28, 2022
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wrote some tests to check for an encoding issue which turned out to be a red herring. There is also some minor cleanup to the related code.
Test Plan
N/A