-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block-generator: Improve payment algorithm to allow sending many more transactions. #864
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #864 +/- ##
===========================================
- Coverage 58.93% 58.53% -0.41%
===========================================
Files 36 37 +1
Lines 4374 4406 +32
===========================================
+ Hits 2578 2579 +1
- Misses 1483 1514 +31
Partials 313 313
Continue to review full report at Codecov.
|
Are you using a config with genesis_account_balance = 10^15? With that number assuming 10K TPS, accounts shouldn't run out of money at least for one day. Also, I'd rather decrease the payment amount; it's simpler and doesn't change the nature of transactions. |
Good call, I wanted to make sure new accounts got extra algod but didn't consider reducing the amount for the other transactions. I think you already updated the genesis account balance. |
I did update it, but are you sure you are not using a custom config? |
8880804
to
c043dec
Compare
c043dec
to
e8cf359
Compare
Summary
Update the block-generator payment algorithm to cycle through accounts if the genesis account runs out of algos.
Test Plan
Accounts were running out of algos during a 1hr run of the jumbo payment scenario, now it isn't.