Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ran updated generator against latest json specs #307

Merged
merged 2 commits into from
Apr 13, 2022
Merged

ran updated generator against latest json specs #307

merged 2 commits into from
Apr 13, 2022

Conversation

barnjamin
Copy link
Contributor

No description provided.

@ahangsu
Copy link
Contributor

ahangsu commented Mar 22, 2022

When I use the generator to run against java sdk, it seems also remove the HashType code in model, do you know what is happening?

@barnjamin
Copy link
Contributor Author

@ahangsu no idea, weird right?

@ahangsu
Copy link
Contributor

ahangsu commented Mar 22, 2022

I believe this problem was also described in algorand/generator#19, not sure how it made its way in generator...

@ahangsu
Copy link
Contributor

ahangsu commented Mar 22, 2022

OK, I remembered it: HashType enum type in Java-SDK will be manually added until stateproof is added to indexer oas2 json.
So I assume it should be just fine to add it back manually...?

ahangsu
ahangsu reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct to me with code changes only in removing JsonProperty decorator from generator code change, waiting on @winder to call the shot.

@winder winder merged commit a1f7d34 into algorand:develop Apr 13, 2022
@onetechnical onetechnical mentioned this pull request Apr 29, 2022
Merged
@onetechnical onetechnical mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahangsu ahangsu ahangsu left review comments

@winder winder winder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnjamin @ahangsu @winder