Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Regenerate Client Interfaces and implement cucumber tests. #555

Merged
merged 9 commits into from
Apr 27, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Apr 26, 2023

See commits for where the auto-pr ends and my changes begin.

This uses and updated generator.
generator PR: algorand/generator#61
codegen diff: 4453df9

Comment on lines +39 to +41
public String getRequestMethod() {
return httpMethod.method();
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for testing.

@winder winder changed the title Regenerate Client Interfaces and implement cucumber tests. api: Regenerate Client Interfaces and implement cucumber tests. Apr 26, 2023
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on Simulate* side

@algochoi
Copy link
Contributor

I think we need to regenerate the models based on algorand/go-algorand#5335

@winder
Copy link
Contributor Author

winder commented Apr 26, 2023

I think we need to regenerate the models based on algorand/go-algorand#5335

Thanks, my local algod repo was stale. Regenerated with the current master and it picked up several changes.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - noting that the simulation endpoints are only generated and not tested.

@winder winder merged commit e37bbe2 into develop Apr 27, 2023
@winder winder deleted the will/sdk-regen branch April 27, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants