-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Regenerate Client Interfaces and implement cucumber tests. #555
Conversation
public String getRequestMethod() { | ||
return httpMethod.method(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good on Simulate*
side
I think we need to regenerate the models based on algorand/go-algorand#5335 |
Thanks, my local algod repo was stale. Regenerated with the current master and it picked up several changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - noting that the simulation endpoints are only generated and not tested.
See commits for where the auto-pr ends and my changes begin.
This uses and updated generator.
generator PR: algorand/generator#61
codegen diff: 4453df9