Use msgpack fork that supports bigints. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
reviewed
Oct 13, 2020
There was a problem hiding this comment.
@EvanJRichard could you add a small test to tests/2.Encoding.js that verifies encoding/decoding a BigInt works as expected?
Pending that, LGTM.
jasonpaulos
approved these changes
Oct 13, 2020
jasonpaulos
pushed a commit
that referenced
this pull request
Oct 14, 2020
A bigint is used only when the decoded number cannot fit in to a Number. Resolves: #130
|
Sorry @EvanJRichard my mistake, now found the correct code but still couldn't find the repo on GitHub |
|
@mxmauro the repo for @EvanJRichard, we should probably update our fork's package.json to point to its repo. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #130. This PR proposes to change the js-sdk to use a fork that supports
BigInt<->uint64encode/decode.See also
Resolves #130