Document that fee will be bumped up to min if finalFee < minFee #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
Transaction
building is done, theTransaction
class checks whether the final fee is below the protocol minimum fee. If it is, the class silently bumps the fee up to the minimum. This surprises user-devs. This PR proposes to addIf the final calculated fee is lower than the protocol minimum fee, the fee will be increased to match the minimum.
to allmain.js
functions involving thefee
.Testing
Docs-only change; leaning on automated testing.
See also
Closes #224