Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firefox tests #235

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Fix firefox tests #235

merged 4 commits into from
Oct 26, 2020

Conversation

jasonpaulos
Copy link
Contributor

  • Switched to an Ubuntu base image for the docker test runner since installing Firefox on Debian proved to be more difficult.
  • Firefox tests were failing because of the issue I pointed out here: Each executed script has a different global scope mozilla/geckodriver#1798. I implemented a workaround to this by using the helper functions makeUint8Array and makeEmptyObject and by fixing how we check for arrays in the SDK.
  • I also found that the code for POST and DELETE requests throw a Response object instead of an Error if an error occurs, so I fixed this to improve the error message that gets displayed.

Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this. I think there was some reason for throwing e.response rather than e, but I can't find that reason documented anywhere. So: LGTM! :shipit:

@jasonpaulos jasonpaulos merged commit 60fe16e into develop Oct 26, 2020
@jasonpaulos jasonpaulos deleted the jason/firefox branch October 26, 2020 19:32
@jasonpaulos jasonpaulos mentioned this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants