New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Transaction constructor handling of arrays #279

Merged

jasonpaulos merged 1 commit into develop from jason/txn-input

Feb 10, 2021

Contributor

jasonpaulos commented Feb 10, 2021

Improve the handling of arrays in the Transaction constructor:

Input arrays (specifically appAccounts) are no longer modified.
All arrays are copied (using map or slice) to avoid modification by the caller after creation.
Additional type checking was added to verify arguments are arrays.

Fixes #273.


          Fix Transaction constructor handling of arrays

9640cc4

jasonpaulos requested a review from algorotem

February 10, 2021 16:15

algorotem approved these changes

View reviewed changes

jasonpaulos merged commit 26efae2 into develop

jasonpaulos deleted the jason/txn-input branch

February 10, 2021 18:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet