Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize errors when they occur for improved error traces #291

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 5, 2021

Fixes #286 by setting error messages instead of initialized Error instances. This allows for error traces to be more informative to the user. Please refer to #286 for additional details.

@jdtzmn jdtzmn requested a review from jasonpaulos March 5, 2021 19:44
@jdtzmn jdtzmn changed the title Initialize named errors when needed for improved error traces Initialize errors when they occur for improved error traces Mar 5, 2021
@jdtzmn jdtzmn force-pushed the jacob/fix-initialized-errors-trace branch from 61c7343 to fa450c2 Compare March 9, 2021 18:36
@jdtzmn jdtzmn marked this pull request as ready for review March 9, 2021 19:05
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jdtzmn jdtzmn merged commit 3c7499f into develop Mar 9, 2021
@jdtzmn jdtzmn deleted the jacob/fix-initialized-errors-trace branch March 9, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize errors when needed for a more useful trace
2 participants