Enhancement: Add foreign array objects to ATC addMethodCall
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnjamin
reviewed
Dec 28, 2022
barnjamin
approved these changes
Dec 29, 2022
jasonpaulos
reviewed
Jan 5, 2023
There was a problem hiding this comment.
Thanks for working on this, it's a much needed improvement. I found one small issue but this looks good to merge after that's addressed.
I agree that we need a new cucumber test to ensure all SDKs have appropriate coverage here, but I don't think that's a blocker for this PR.
jasonpaulos
approved these changes
Jan 10, 2023
algochoi
added a commit
that referenced
this pull request
Jan 18, 2023
* ABI: Refactor ABI encoding test to round-trip (#701) * bump version and add to changelog * update README.md for new version * Packaging: Improve source map and browser usage for external bundlers (#707) * bump version and add to changelog * update README.md for new version * v2: Make breaking changes from v1 to v2.0.0 (#717) * bump version and add to changelog * update README.md for new version * remove enhancement section of recent changelog * Enhancement: Add foreign array objects to ATC `addMethodCall` (#725) * Add foreign array objects to ATC addmethodcall * Copy array value so that inputs are not modified Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: Lucky Baar <[email protected]> Co-authored-by: Jason Paulos <[email protected]> Co-authored-by: Jack Smith <[email protected]> Co-authored-by: Barbara Poon <[email protected]>
algochoi
added a commit
that referenced
this pull request
Jan 18, 2023
* Add test for algod /v2/teal/disassemble * Merge develop into PR (#736) * ABI: Refactor ABI encoding test to round-trip (#701) * bump version and add to changelog * update README.md for new version * Packaging: Improve source map and browser usage for external bundlers (#707) * bump version and add to changelog * update README.md for new version * v2: Make breaking changes from v1 to v2.0.0 (#717) * bump version and add to changelog * update README.md for new version * remove enhancement section of recent changelog * Enhancement: Add foreign array objects to ATC `addMethodCall` (#725) * Add foreign array objects to ATC addmethodcall * Copy array value so that inputs are not modified Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: Lucky Baar <[email protected]> Co-authored-by: Jason Paulos <[email protected]> Co-authored-by: Jack Smith <[email protected]> Co-authored-by: Barbara Poon <[email protected]> * Explicitly import Buffer * Revert test branch back to master Co-authored-by: algochoi <[email protected]> Co-authored-by: Lucky Baar <[email protected]> Co-authored-by: Jason Paulos <[email protected]> Co-authored-by: Jack Smith <[email protected]> Co-authored-by: Barbara Poon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds foreign array objects as arguments in
addMethodCall()for the atomic transaction composer.Adds a test that mirrors the Go SDK: algorand/go-algorand-sdk#318. Currently written as a unit test, but could also benefit from a cucumber test since all the other SDKs implement this.
Addresses #653