Add address bytes length check in encodeAddress #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
commented
Aug 8, 2023
| algosdk.base64ToBytes(globalState.value.bytes) | ||
| ); | ||
| // show global value | ||
| const globalValue = globalState.value.bytes; |
There was a problem hiding this comment.
This seemed to be a zero-length byte array in the example test
winder
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds check when encoding address to string that address is 32 bytes. Also fixes an example that would fail this check because it passes an empty bytearray to encode. Targets the v3 branch.
#805