Remove "nonParticipation: true" from offlineKeyReg example #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop the v2 from the links in the docs
example improvements
Support updated simulate endpoint with the request object.
joe-p
force-pushed
the
rm_non_participation
branch
from
a7afbc1
to
56f0c2a
Compare
|
This seems like a good fix. However, I don't think this merges in the latest develop. There are more commits in develop after 88aa843. Particularly, there is ed020a4, which updates our node version from 14 to 16. Right now this branch uses 14 and our chromedriver dependency can no longer run (it looks like we may need to update again to node 18 to get it to work [edit: I made #827 to fix this]). |
|
Fixed by #866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offlineKeyReg example included
nonParticipation: truewhich means the account can no longer participate, which is irreversible. This should not be shown in the example code.Also merges in latest develop