Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: native esm bundle #836

Merged
merged 14 commits into from
Jan 5, 2024
Merged

chore: native esm bundle #836

merged 14 commits into from
Jan 5, 2024

Conversation

PhearZero
Copy link
Contributor

@PhearZero PhearZero commented Oct 16, 2023 •
edited
Loading

Overview

  • Allows for native esm imports of algosdk
  • Configures exports field of package.json
  • Uses TSX as a replacement for ts-node

Remaining

  • Validate third party type consumers
  • Validate happy path type inference
  • Refine exports field

Issues

@PhearZero PhearZero mentioned this pull request Oct 16, 2023
Closed
2 tasks
@PhearZero
feat: add barrel files for clients
6c4e7f0 
chore:  cleanup exports key
@PhearZero PhearZero marked this pull request as ready for review November 13, 2023 12:54
@RobbyUitbeijerse RobbyUitbeijerse mentioned this pull request Dec 3, 2023
Open
jasonpaulos
jasonpaulos approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the error in the cucumber browser tests and made some minor tweaks to a few exports, and this looks mergable now. Thanks for putting in the effort to make this PR

@jasonpaulos jasonpaulos merged commit 1947079 into algorand:3.0.0 Jan 5, 2024
2 checks passed
@jasonpaulos jasonpaulos mentioned this pull request Feb 15, 2024
Closed
@jasonpaulos jasonpaulos mentioned this pull request Mar 26, 2024
Open
@jasonpaulos jasonpaulos mentioned this pull request Aug 21, 2024
Closed
@onetechnical onetechnical mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhearZero @jasonpaulos