Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: add check to desc so we dont output null if undefined #368

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

barnjamin
Copy link
Contributor

This seems to choke the js-sdk which is expecting string | undefined

When there is a None in the dict, the json dumped includes null

>>> x = {'z':None}
>>> import json
>>> json.dumps(x)
'{"z": null}'

Other dictify methods have checks for this (Method/Args)

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this - it looks like we (me) added this check for the method and interface but not for the contract.

@barnjamin barnjamin changed the title add check to desc so we dont output null if undefined bug-fix: add check to desc so we dont output null if undefined Aug 10, 2022
@barnjamin barnjamin merged commit 7c1fb44 into develop Aug 10, 2022
@barnjamin barnjamin deleted the null-desc branch August 10, 2022 15:46
ahangsu added a commit that referenced this pull request Sep 2, 2022
* add check to desc so we dont output null if undefined (#368)

* Bumped version to v1.16.1

* Enhancement: Trim the indexer images and use the sandbox instead of custom dockers (#367)

Co-authored-by: algochoi <[email protected]>
Co-authored-by: Michael Diamant <[email protected]>

* Bug-fix: Pass verbosity through to testing harness (#373)

* Enhancement: Add State Proof support (#370)

* add stateproof support

* Enhancement: Deprecating use of langspec  (#371)

* Bumped version to v1.17.0

* Update README.md

Co-authored-by: Zeph Grunschlag <[email protected]>

* Mergeback: Release v1.17.0b1 (#378)

* Bumped version
* Update README.md

* bumped version to v1.17.0

Co-authored-by: Ben Guidarelli <[email protected]>
Co-authored-by: Barbara Poon <[email protected]>
Co-authored-by: Zeph Grunschlag <[email protected]>
Co-authored-by: algochoi <[email protected]>
Co-authored-by: Michael Diamant <[email protected]>
Co-authored-by: shiqizng <[email protected]>
Co-authored-by: Jack Smith <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Lucky Baar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants