Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker version command #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Jun 15, 2023

When using a custom build of docker, docker compose version will only return the commit hash and not the release version.

$ docker compose version
Docker Compose version dde0213

$ docker compose version --format json
{"version":"dde0213"}

For the version parsing to work, docker --version must be used:

$ docker --version
Docker version 23.0.3, build 3e7cbfd

@@ -284,4 +284,4 @@ def fetch_indexer_status_data(service_info: dict[str, Any]) -> dict[str, Any]:
return {"Status": "Error"}


DOCKER_COMPOSE_VERSION_COMMAND = ["docker", "compose", "version", "--format", "json"]
DOCKER_COMPOSE_VERSION_COMMAND = ["docker", "--version"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the docker version rather than docker compose, if we used this we'd need to change the version we look for (we look for compose 2.5+ from memory because that was the point it was stable with bug patches for things users of algokit would likely come across.

@robdmoore
Copy link
Contributor

Looping back here, what should we do @joe-p? When does a custom docker build get used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants