Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input type for uintN[], N > 51 #119

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Aug 2, 2024

Proposed Changes

  • Input types for large uintN[] are bigint | number[]. This PR fixes it so it's correctly bigint[] | number[]

Fixes #118

@pbennett
Copy link

pbennett commented Aug 2, 2024

Is this something that would go to just bigint[] once the sdk is completely converted over?

Copy link
Contributor

@neilcampbell neilcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks!

@neilcampbell neilcampbell merged commit 49e5167 into main Aug 2, 2024
1 check passed
@neilcampbell neilcampbell deleted the fix/input_uint64_array branch August 2, 2024 15:34
@joe-p
Copy link
Contributor Author

joe-p commented Aug 2, 2024

Is this something that would go to just bigint[] once the sdk is completely converted over?

There's no plans to change this for the generated client. Newer features in algokit such as AlgokitComposer and the upcoming ARC56 app client will enforce usage of BigInt, but no breaking changes will be made to these ARC32-based generated clients.

@neilcampbell
Copy link
Contributor

neilcampbell commented Aug 2, 2024

Released in 3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uint64[] args result in incorrect types
3 participants