fix: Don't raise on div 0 in optimizer as the operation might be pre-…

…checked for != 0 in previous operations
algorandfoundation · Jan 31, 2024 · 6d549ed · 6d549ed
1 parent 4d2eb31
commit 6d549ed
Show file tree

Hide file tree

Showing 93 changed files with 13,009 additions and 13,365 deletions.
diff --git a/examples/amm/puya.log b/examples/amm/puya.log
diff --git a/examples/auction/puya.log b/examples/auction/puya.log
diff --git a/examples/calculator/puya.log b/examples/calculator/puya.log
diff --git a/examples/global_state/puya.log b/examples/global_state/puya.log
diff --git a/examples/hello_world/puya.log b/examples/hello_world/puya.log
diff --git a/examples/local_state/puya.log b/examples/local_state/puya.log
diff --git a/examples/sizes.txt b/examples/sizes.txt
@@ -3,10 +3,10 @@ abi_routing                          795              730
 address_constant                     43               43
 amm                                  1198             1131
 application                          163              163
-arc4_types/array                     603              487
+arc4_types/array                     622              487
 arc4_types/bool                      322              59
 arc4_types/dynamic_string_array      249              167
-arc4_types/mutation                  2886             1823
+arc4_types/mutation                  2926             1861
 arc4_types/numeric                   353              214
 arc4_types/string                    344              305
 arc4_types/structs                   291              221
@@ -26,7 +26,7 @@ conditional_execution                380              344
 conditional_expressions              228              182
 contains                             155              156
 edverify                             39               33
-enumeration                          542              506
+enumeration                          633              586
 everything                           467              457
 global_state                         319              315
 hello_world                          19               18
@@ -37,21 +37,22 @@ less_simple                          93               87
 local_state/local_state_contract     319              314
 local_state/local_state_with_offsets 332              326
 match                                486              467
-nested_loops                         228              203
-scratch_slots                        64               63
-scratch_slots/contract2              64               63
+nested_loops                         369              203
+reversed_iteration                   783              618
+scratch_slots                        78               63
+scratch_slots/contract2              78               63
 simple                               51               4
 simplish                             741              725
-ssa                                  235              212
-ssa2                                 49               46
+ssa                                  267              212
+ssa2                                 77               46
 string_ops                           150              148
 stubs/biguint                        158              140
 stubs/bytes                          645              4
 stubs/uint64                         366              4
 transaction                          685              677
-tuple_support                        434              306
+tuple_support                        455              326
 unary                                129              92
 undefined_phi_args/baddie            346              346
-unssa                                433              378
-voting/voting                        1594             1530
+unssa                                473              420
+voting/voting                        1646             1565
 with_reentrancy                      259              240
diff --git a/examples/voting/puya.log b/examples/voting/puya.log
diff --git a/src/puya/ir/optimize/arithmetic.py b/src/puya/ir/optimize/arithmetic.py
@@ -240,13 +240,9 @@ def try_simplify_arithmetic_ops(value: models.ValueProvider) -> models.ValueProv
                         c = a_const - b_const
                     case AVMOp.mul:
                         c = a_const * b_const
-                    case AVMOp.div_floor:
-                        if b_const == 0:
-                            raise CodeError("// would fail at runtime (div 0)", b.source_location)
+                    case AVMOp.div_floor if b_const != 0:
                         c = a_const // b_const
-                    case AVMOp.mod:
-                        if b_const == 0:
-                            raise CodeError("mod would fail at runtime (div 0)", b.source_location)
+                    case AVMOp.mod if b_const != 0:
                         c = a_const % b_const
                     case AVMOp.lt:
                         c = 1 if a_const < b_const else 0

diff --git a/test_cases/abi_routing/puya.log b/test_cases/abi_routing/puya.log
diff --git a/test_cases/address_constant.puya.log b/test_cases/address_constant.puya.log
diff --git a/test_cases/application/puya.log b/test_cases/application/puya.log
diff --git a/test_cases/arc4_types/out/mutation.approval.debug.teal b/test_cases/arc4_types/out/mutation.approval.debug.teal