-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest updates and changes #37
base: main
Are you sure you want to change the base?
Conversation
ReadMe update
…cation data state
…nd separation of application data from the network layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome changes, adding more elegance and robustness to the foundations. Decoupling the AppState from Core makes things a lot more breathable.
Here's a first pass of revision. Everything in this review is really just documentation cosmetics. I made a commit to update some of the docs on the variants (was easier than to do in the Github UI). Before merging this PR and because it contains major breaking changes, I will do another pass on this for:
- Testing all core library code again
- Running the examples
Wanted to get this first review in quick. Cheers!
@thewoodfish : can you go ahead an commit my suggestions or comment on anything I may've missed please? 🙏🏻 Then I'll be able to pull locally and make some additional amendments in a separate commit as part of my second review. |
For code review and test coverage [WIP]. Tests to write around events are pushed into an internal buffer that gets polled.
More to consider: updates / end-user docs for adapting to breaking changes -- these need updating. |
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
Co-authored-by: Sacha Lansky <[email protected]>
…y() instead of new()
Breaking Changes in the Latest Version
In the latest version of our library, we have introduced two major updates that bring significant improvements but also include breaking changes:
Better Handling Interface for Network Events:
Separation of Application Data from the Network Layer:
These updates are significant and introduce breaking changes. Please refer to the updated documentation for guidance on how to migrate to the new version.