Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transform] add disc_linalg_ext::multi_level_pack op #838

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

wyzero
Copy link
Collaborator

@wyzero wyzero commented Dec 6, 2022

to #787

@wyzero wyzero requested a review from qiuxiafei December 6, 2022 11:21
Copy link
Collaborator

@qiuxiafei qiuxiafei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

@@ -388,6 +389,7 @@ def bazel_test(target, flag=""):
if targets is not None and target not in targets:
return
logger.info("Testing bazel target: " + target)
flag += " --experimental_ui_max_stdouterr_bytes=-1 "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be in ./tao_compiler/.bazelrc.user.

disc_linalg_ext.multi_level_pack %arg0 with padding_value(%pad : f32)
tile_levels = [1, 1] tile_sizes = [8, 2] permutation = [0, 2, 1, 3]
into %arg1 : (tensor<13x15xf32> tensor<2x8x8x2xf32>)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll update this in the next pr to reduce some CI overhead.

@wyzero wyzero merged commit fa4a4b8 into alibaba:main Dec 7, 2022
@wyzero wyzero deleted the features/wenyi_fix branch December 7, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants