You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wrong resource name resolved in ClusterNode-related commands (e.g. tree, cnode and clusterNode) for SphU.entry(method). The actual resource name for the ClusterNode is correct (full-qualified, classes with package name), but when we get all ClusterNode from related API commands, the displayed resource name will be simplified (i.e. package name is omitted).
For example, for the method com.alibaba.csp.demo.DemoService:foo(java.lang.String), the displayed name will be DemoService:foo(String).
This is caused by the getShowName method of MethodResourceWrapper, which will simplify the FQN of the method.
This bug will also affect the resource display in the dashboard, as the data depends on the command center of Sentinel transport module. This could mislead developers.
Describe what you expected to happen
The resource name for the Method instance should be full-qualified.
How to reproduce it (as minimally and precisely as possible)
Assume we have a method com.alibaba.csp.sentinel.dashboard.controller.DemoController#link, we get the Method instance via reflection API.
Then invoke SphU.entry(method), we can see this in the log: Add child <com.alibaba.csp.sentinel.dashboard.controller.DemoController:link()> to node <xxx>
Execute curl localhost:8719/tree, we cound find wrong name DemoController:link() here:
Issue Description
Type: bug report
Describe what happened (or what feature you want)
Wrong resource name resolved in ClusterNode-related commands (e.g.
tree
,cnode
andclusterNode
) forSphU.entry(method)
. The actual resource name for the ClusterNode is correct (full-qualified, classes with package name), but when we get all ClusterNode from related API commands, the displayed resource name will be simplified (i.e. package name is omitted).For example, for the method
com.alibaba.csp.demo.DemoService:foo(java.lang.String)
, the displayed name will beDemoService:foo(String)
.This is caused by the
getShowName
method ofMethodResourceWrapper
, which will simplify the FQN of the method.This bug will also affect the resource display in the dashboard, as the data depends on the command center of Sentinel transport module. This could mislead developers.
Describe what you expected to happen
The resource name for the
Method
instance should be full-qualified.How to reproduce it (as minimally and precisely as possible)
com.alibaba.csp.sentinel.dashboard.controller.DemoController#link
, we get theMethod
instance via reflection API.SphU.entry(method)
, we can see this in the log:Add child <com.alibaba.csp.sentinel.dashboard.controller.DemoController:link()> to node <xxx>
curl localhost:8719/tree
, we cound find wrong nameDemoController:link()
here:Tell us your environment
Sentinel 1.7.0-SNAPSHOT in
master
branchAnything else we need to know?
NONE
The text was updated successfully, but these errors were encountered: