Fix the bug that resource name displayed in ClusterNode-related command APIs for SphU.entry(method) is incorrect #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pper Signed-off-by: Eric Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
============================================
+ Coverage 42.98% 43.05% +0.07%
- Complexity 1492 1493 +1
============================================
Files 317 317
Lines 9320 9320
Branches 1272 1272
============================================
+ Hits 4006 4013 +7
+ Misses 4819 4815 -4
+ Partials 495 492 -3
Continue to review full report at Codecov.
|
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…nd APIs for SphU.entry(method) is incorrect (alibaba#1078) Signed-off-by: Eric Zhao <[email protected]>
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
…ey don't copy the tool.yml file to related fold and AclEnable flag is closed. (alibaba#1079) * [issue#1078]fix User can't use mqadmin command normally if they don't copy the tool.yml file to their related fold and AclEnable flag is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao [email protected]
Describe what this PR does / why we need it
Fix the bug that resource name displayed in
ClusterNode-related command APIs forSphU.entry(method)is incorrect.Does this pull request fix one issue?
Fixes #1077
Describe how you did it
Return the original method name directly in
getShowName()ofMethodResourceWrapper, since the truncated name seems useless.Describe how to verify it
Try
SphU.entry(method)and see the display name viatreecommand API.Special notes for reviews
NONE.