Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring project.name via the properties file #1191

Closed
sczyh30 opened this issue Dec 6, 2019 · 3 comments · Fixed by #1412
Closed

Support configuring project.name via the properties file #1191

sczyh30 opened this issue Dec 6, 2019 · 3 comments · Fixed by #1412
Labels
area/configuration Issues or PRs related to configurations of Sentinel good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Milestone
1.8.0

Comments

@sczyh30
Copy link
Member

sczyh30 commented Dec 6, 2019

Issue Description

Type: feature request

Describe what happened (or what feature you want)

Since 1.7.0, Sentinel has supported configuration via the properties file (except the project.name property). The project.name property is not supported due to the legacy logic (compatible with the legacy default path ~/logs/csp/${appName}.properties), which is rarely used. So we may deprecate the legacy logic in the next few versions and then support configuring project.name via the properties file.

Further discussions are welcomed!
@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. area/configuration Issues or PRs related to configurations of Sentinel labels Dec 6, 2019
@sczyh30
Copy link
Member Author

sczyh30 commented Dec 6, 2019

Also refer to #804

@wavesZh
Copy link
Contributor

wavesZh commented Dec 7, 2019

I will finish it

wavesZh added a commit to wavesZh/Sentinel that referenced this issue Dec 7, 2019
@wavesZh
Support configuring project.name via the properties file alibaba#1191
2a044af
@sczyh30
Copy link
Member Author

sczyh30 commented Dec 7, 2019

Good. Compatibility and implicit class dependency should be considered carefully.

wavesZh added a commit to wavesZh/Sentinel that referenced this issue Dec 7, 2019
@wavesZh
Support configuring project.name via the properties file alibaba#1191
1061dbf
@wavesZh wavesZh mentioned this issue Dec 7, 2019
Closed
@sczyh30 sczyh30 mentioned this issue Dec 26, 2019
Closed
@sczyh30 sczyh30 added the good first issue Good for newcomers label Apr 15, 2020
@sczyh30 sczyh30 added this to the 1.8.0 milestone Apr 15, 2020
@linlinisme linlinisme mentioned this issue Apr 18, 2020
Merged
@sczyh30 sczyh30 mentioned this issue Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/configuration Issues or PRs related to configurations of Sentinel good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

[1191] Support configuring project.name via the properties file linlinisme/Sentinel
2 participants
@sczyh30 @wavesZh