Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logback extension module for Sentinel logger SPI #1340

Closed
sczyh30 opened this issue Mar 16, 2020 · 3 comments
Closed

Add logback extension module for Sentinel logger SPI #1340

sczyh30 opened this issue Mar 16, 2020 · 3 comments
Labels
area/integrations Issues or PRs related to integrations with open-source components area/logging Issues or PRs related to logging of Sentinel wontfix This will not be worked on

Comments

@sczyh30
Copy link
Member

sczyh30 commented Mar 16, 2020

Issue Description

Umbrella issue: #1295

Type: feature request

Describe what happened (or what feature you want)

Add logback extension module (sentinel-logging-extension-logback in sentinel-extension) for Sentinel logger SPI. We may refer to the logback sample and #757 (comment)

Contributions are welcomed!
@sczyh30 sczyh30 added good first issue Good for newcomers area/integrations Issues or PRs related to integrations with open-source components area/logging Issues or PRs related to logging of Sentinel labels Mar 16, 2020
@jasonjoo2010 jasonjoo2010 mentioned this issue Mar 16, 2020
Closed
1 task
@sczyh30 sczyh30 mentioned this issue Mar 16, 2020
Open
@zhaoyuguang zhaoyuguang mentioned this issue Mar 23, 2020
Closed
@zhaoyuguang
Copy link
Collaborator

I wanna try to finish it

@jasonjoo2010
Copy link
Collaborator

I wanna try to finish it

Good to hear that.
And please pay attention to recent changes which will be merged: #1355
You may rebase to the newest code before submitting.

@sczyh30
Copy link
Member Author

sczyh30 commented Jul 27, 2020

As it's rare to use the loggers of the logging framework directly (without slf4j), I think this issue is no longer necessary and can be closed. Please reopen the issue if needed :)

Thanks for your contribution! @zhaoyuguang

@sczyh30 sczyh30 closed this as completed Jul 27, 2020
@sczyh30 sczyh30 added wontfix This will not be worked on and removed good first issue Good for newcomers labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integrations Issues or PRs related to integrations with open-source components area/logging Issues or PRs related to logging of Sentinel wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logback extension module for Sentinel logger SPI zhaoyuguang/Sentinel
3 participants
@sczyh30 @zhaoyuguang @jasonjoo2010