-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging SPI for various logging libraries #757
Comments
Sentinel is a fundamental component so Maybe we can make the logging interface as SPI and provide different implementations (based on JUL or slf4j). Discussions are welcomed. |
i'm every agree to support making the logging interface as SPI and provide different implementations |
I think Logging SPI is pretty important since I find it's impossible to control the size and the count of log file "sentinel-block.log","sentinel-record.log" and "command-center.log".(They are all hard coded in codes) |
This can be improved. We might need more configuration items to control the different logs (e.g. record log, metric log and block log). For logging SPI we need more discussion (whether to support and how to support). @cdfive @jasonjoo2010 @linlinisme Any suggestions? |
Indeed it's a meaningful feature for most users. We can provide it as an SPI protocol and make several implementations in separated modules including slf4j/log4j/jcl logging system forwarder, standard console output, etc. Certainly it will also enable users to implement it themselves. |
能否支持采用slf4j做日志记录框架API? |
the log is bad implement by write String to assign log file,cannot we use slf4j or other implements such as we support event(EventBus or SpringApplicationEvent) to log,
is it more scalable?zhe sentinel‘s user can feel comfortable。
such as:
EventBus.post(LogEvent log);
new Listener(){
doLog(){
log.info();
}
}
The text was updated successfully, but these errors were encountered: