Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature support dubbo 2.7.6 #1381

Closed
seasidesky opened this issue Apr 5, 2020 · 2 comments
Closed

feature support dubbo 2.7.6 #1381

seasidesky opened this issue Apr 5, 2020 · 2 comments
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Milestone
1.8.0

Comments

@seasidesky
Copy link
Contributor

Issue Description

according to 2.7.6-release-note and Filter refactor, keep all callback methods inside Filter.Listener #5731 Filter.Listener in 2.7.4 and 2.7.5 is not compatible with 2.7.3 and 2.7.6.

Describe what happened (or what feature you want)

current sentinel-apache-dubbo-adapter do not support dubbo 2.7.6

Describe what you expected to happen

add feature to make sentinel-apache-dubbo-adapter support dubbo 2.7.6

How to reproduce it (as minimally and precisely as possible)

ListenableFilter was deperated in dubbo 2.7.6 and onMessage method is renamed back to onResponse according to 2.7.6-release-note and Filter refactor, keep all callback methods inside Filter.Listener #5731

Tell us your environment

Anything else we need to know?
@cdfive cdfive added area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement. labels Apr 5, 2020
@cdfive
Copy link
Collaborator

cdfive commented Apr 5, 2020 •
edited
Loading

Thanks for pointing out the compatibility problem in detail!
Since dubbo 2.7.6 has breaking change onFilter, it seems not easy to be compatible with multiple versions in one module.
Discussions and contributions are welcomed.

@sczyh30 sczyh30 added this to the 1.7.3 milestone Apr 6, 2020
@seasidesky seasidesky mentioned this issue Apr 6, 2020
Closed
@sczyh30 sczyh30 added the good first issue Good for newcomers label Apr 26, 2020
@sczyh30
Copy link
Member

sczyh30 commented Aug 20, 2020

Already resolved via #1431
Thanks for your contribution! @seasidesky

@sczyh30 sczyh30 closed this as completed Aug 20, 2020
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@RongtongJin @duhenglucky
Polish lite pull consumer (alibaba#1381)
c6096a1 
* fix unsubscribe code

* fix commit consumed offset

* fix commit consumed offset

* fix commit consumed offset

* fix commit consumed offset

* polish commit consumed offset

* pass checkstyle

* pass checkstyle

* polish LiteMQPullConsumer

* add flow control and polish commit logic

* fix bug

* polish code

* fix commit consumed offset back

* refactor litePullConsumer

* development save

* development save

* Refactor DefaultLitePullConsumer and DefaultLitePullConsumerImpl.

* Polish lite pull consumer

* polish lite pull consumer

* polish lite pull consumer

* fix seek

* fix seek function

* polish lite pull consumer

* add apache header

* add test

* polish test

* Make broadcast model work for litePullConsumer

* Revert example/broadcast/PushConsumer.java

* Add delay time when no new message

* Enable long polling mode

* Fix subscribe bug when rebalance

* Delete useless consumeMessageHook

* Implement TopicMessageQueueChangeListener interface

* Lite pull consumer support namespace

* Make sql92 filter work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

[feature]add apache dubbo 2.7.6 support seasidesky/Sentinel
3 participants
@sczyh30 @cdfive @seasidesky