Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]Overrunning test FlowRuleManagerTest.testLoadAndGetRules #1822

Closed
jasonjoo2010 opened this issue Oct 27, 2020 · 1 comment · Fixed by #1823
Closed

[BUG]Overrunning test FlowRuleManagerTest.testLoadAndGetRules #1822

jasonjoo2010 opened this issue Oct 27, 2020 · 1 comment · Fixed by #1823
Assignees
@jasonjoo2010
Labels
kind/bug Category issues or prs related to bug.
Milestone
1.8.1

Comments

@jasonjoo2010
Copy link
Collaborator

Issue Description

In the previous PR #1783 there was an issued test case that had a thread that may overrun its lifecycle. This would cause an obstruction in the following cases.

Describe what happened (or what feature you want)

Test cases became unstable.

Describe what you expected to happen

All related resources and processes should be limited in the case.

How to reproduce it (as minimally and precisely as possible)

In integration tests in travis-ci.

Anything else we need to know?

No.
@jasonjoo2010 jasonjoo2010 added the kind/bug Category issues or prs related to bug. label Oct 27, 2020
@jasonjoo2010 jasonjoo2010 added this to the 1.8.1 milestone Oct 27, 2020
@jasonjoo2010 jasonjoo2010 self-assigned this Oct 27, 2020
@jasonjoo2010 jasonjoo2010 mentioned this issue Oct 27, 2020
Merged
@sczyh30 sczyh30 linked a pull request Oct 29, 2020 that will close this issue
Fix overrunning test FlowRuleManagerTest.testLoadAndGetRules #1823
Merged
@sczyh30
Copy link
Member

sczyh30 commented Oct 29, 2020

Resolved in #1823

@sczyh30 sczyh30 closed this as completed Oct 29, 2020
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@duhenglucky
Merge pull request alibaba#1822 from RongtongJin/fix_1821
d7102c0 
[ISSUE alibaba#1821]Fix the issue that MessageClientIDSetter#getIPFromID return wrong pid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonjoo2010 jasonjoo2010

Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Fix overrunning test FlowRuleManagerTest.testLoadAndGetRules jasonjoo2010/Sentinel
2 participants
@sczyh30 @jasonjoo2010