Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Sentinel Dashboard should not allow invalid values when configuring rules #198

Closed
yikangfeng opened this issue Oct 26, 2018 · 0 comments · Fixed by #202
Closed

[Bug] Sentinel Dashboard should not allow invalid values when configuring rules #198

yikangfeng opened this issue Oct 26, 2018 · 0 comments · Fixed by #202
Assignees
@sczyh30
Labels
kind/bug Category issues or prs related to bug.
Milestone
1.3.0

Comments

@yikangfeng
Copy link
Contributor

yikangfeng commented Oct 26, 2018 •
edited by sczyh30
Loading

Issue Description

Type: bug report

Describe what happened (or what feature you want)

sentinel 0.2.0 dashboard 配置 限流，降级，系统规则所有涉及到填写数字目前可以是负数

Describe what you expected to happen

Do not allow invalid values in rules.

How to reproduce it (as minimally and precisely as possible)

  1. Add a degrade rule with negative degrade window in Sentinel Dashboard.

Tell us your environment

  • Sentinel 0.2.0 dashboard

Anything else we need to know?
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Oct 26, 2018
@sczyh30 sczyh30 changed the title sentinel 0.2.0 dashboard 配置 限流，降级，系统规则所有涉及到填写数字目前可以是负数 [Bug] Sentinel Dashboard should not allow invalid values when configuring rules Oct 26, 2018
@sczyh30 sczyh30 self-assigned this Oct 26, 2018
@sczyh30 sczyh30 added this to the 1.3.0 milestone Oct 26, 2018
@sczyh30 sczyh30 mentioned this issue Oct 26, 2018
Merged
sczyh30 added a commit that referenced this issue Oct 29, 2018
@sczyh30
Fixes #198: Enhance rule checking in rule managers and Sentinel Dashb…
0c15dd9 
…oard (#202)

- Enhance rule checking in rule managers and Sentinel Dashboard frontend
- Enhance error information when reporting invalid fields in rule dialog

Signed-off-by: Eric Zhao <[email protected]>
@pouchrobot pouchrobot mentioned this issue Nov 2, 2018
Closed
Arlmls pushed a commit to Arlmls/Sentinel that referenced this issue Jan 8, 2019
@sczyh30
Fixes alibaba#198: Enhance rule checking in rule managers and Sentine…
c4a8ff1 
…l Dashboard (alibaba#202)

- Enhance rule checking in rule managers and Sentinel Dashboard frontend
- Enhance error information when reporting invalid fields in rule dialog

Signed-off-by: Eric Zhao <[email protected]>
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@dongeforever @vongosling
[ROCKETMQ-321] Fix deleting files in the middle (alibaba#198)
390f735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sczyh30 sczyh30

Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Fixes #198: Enhance rule checking in rule managers and Sentinel Dashboard alibaba/Sentinel
2 participants
@yikangfeng @sczyh30