Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement of carrying args in entry.exit() #3109

Closed
sczyh30 opened this issue Apr 27, 2023 · 0 comments · Fixed by #3114
Closed

Remove the requirement of carrying args in entry.exit() #3109

sczyh30 opened this issue Apr 27, 2023 · 0 comments · Fixed by #3114
Labels
good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Milestone

Comments

@sczyh30
Copy link
Member

sczyh30 commented Apr 27, 2023

Issue Description

Type: enhancement

Describe what feature you want

Remove the requirement of carrying args in entry.exit().

目前对于带参数的自定义埋点,entry.exit() 的时候需要也带上埋点的参数(比如 entry.exit(arg1, arg2)),这样使用起来不太方便。期望最终实现 exit 时不需要带上埋点的参数以及 batchCount。

Describe your initial design (if present)

Hold args in Entry so that users don't need to carry args or argMap on Entry exit.

@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. good first issue Good for newcomers labels Apr 27, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue May 4, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue May 4, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue May 4, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue May 4, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue May 4, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue May 30, 2023
LiYangSir added a commit to LiYangSir/Sentinel that referenced this issue Jun 14, 2023
@sczyh30 sczyh30 added this to the v2.0.0 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant