Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel 什么时候可以支持 Spring 6 / spring-boot 3 ? #3191

Closed
ldcsaa opened this issue Aug 1, 2023 · 5 comments · Fixed by #3351
Closed

Sentinel 什么时候可以支持 Spring 6 / spring-boot 3 ? #3191

ldcsaa opened this issue Aug 1, 2023 · 5 comments · Fixed by #3351
Labels
area/integrations Issues or PRs related to integrations with open-source components

Comments

@ldcsaa
Copy link

ldcsaa commented Aug 1, 2023

如题~

CommonFilter 继承的是 javax.servlet.Filter,但 Spring 6 用的是 jakarta.servlet.Filter,无法使用了。

@sczyh30 sczyh30 added the area/integrations Issues or PRs related to integrations with open-source components label Aug 2, 2023
@903328615
Copy link

我也发现了,怕不是得自己重写一个,之前还有个 issue ,不会不维护了吧

@sczyh30
Copy link
Member

sczyh30 commented Aug 3, 2023

Refer this PR: #2997

目前针对 JDK 17 的 CI 还有些问题,测试用例与依赖需要做下完善(refer #3015),这一块没问题后会合并相关 PR.

@ruansheng8
Copy link
Contributor

@sczyh30 CI 这块是否有计划修复,Sentinel 1.8.7 版本没有 sentinel-spring-webmvc-6x-adapter 这个模块。

之前 1.8.6 版本是本地直接 deploy 到远程仓库的

image

@LearningGp
Copy link
Collaborator

我会尝试在近期修复这个问题

@ruansheng8
Copy link
Contributor

ruansheng8 commented Feb 22, 2024

我会尝试在近期修复这个问题

@LearningGp @sczyh30 我关注到最近有几个 CI 的 PR 被合并,是否意味着该问题已经被修复,可以准备合并 Sentinel 适配 Spring 6 相关的支持PR

This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants