Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spring boot 3.x #3351

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Support spring boot 3.x #3351

merged 4 commits into from
Mar 1, 2024

Conversation

robberphex
Copy link
Collaborator

Describe what this PR does / why we need it

  • Add module sentinel-spring-webmvc-v6x-adapter, which hold package com.alibaba.csp.sentinel.adapter.spring.webmvc_v6x, for modularity.
  • Upload coverage reports to Codecov.

Does this pull request fix one issue?

Fix #2986, fix #3191, fix #2997.

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 53.93258% with 82 lines in your changes missing coverage. Please review.

Project coverage is 45.88%. Comparing base (d995dfe) to head (13a8f17).
Report is 19 commits behind head on 1.8.

Files with missing lines Patch % Lines
...spring/webmvc_v6x/AbstractSentinelInterceptor.java 66.10% 12 Missing and 8 partials ⚠️
...pring/webmvc_v6x/config/WebServletLocalConfig.java 0.00% 18 Missing ⚠️
...ing/webmvc_v6x/config/SentinelPreWebMvcConfig.java 0.00% 13 Missing ⚠️
...pter/spring/webmvc_v6x/SentinelWebInterceptor.java 45.00% 6 Missing and 5 partials ⚠️
...spring/webmvc_v6x/config/SentinelWebMvcConfig.java 62.96% 8 Missing and 2 partials ⚠️
...pring/webmvc_v6x/SentinelWebPrefixInterceptor.java 0.00% 5 Missing ⚠️
...spring/webmvc_v6x/SentinelWebTotalInterceptor.java 50.00% 3 Missing and 1 partial ⚠️
...g/webmvc_v6x/config/SentinelWebMvcTotalConfig.java 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.8    #3351      +/-   ##
============================================
+ Coverage     45.77%   45.88%   +0.10%     
- Complexity     2104     2141      +37     
============================================
  Files           420      430      +10     
  Lines         12722    12900     +178     
  Branches       1712     1730      +18     
============================================
+ Hits           5824     5919      +95     
- Misses         6218     6284      +66     
- Partials        680      697      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit 669595d into alibaba:1.8 Mar 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentinel 什么时候可以支持 Spring 6 / spring-boot 3 ? Add support for Spring Boot 3.x (Spring 6.x)
4 participants