Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can MetricWriter and MetricReader be abstracted into interfaces and support SPI extensions? #468

Open
kangyl opened this issue Jan 28, 2019 · 2 comments
Labels
area/metrics Issues or PRs related to metrics and monitoring kind/feature Category issues or prs related to feature request.

Comments

@kangyl
Copy link
Contributor

kangyl commented Jan 28, 2019

Issue Description

Type: feature request

Describe what feature you want

MetricWriter ,MetricReader,MetricsReader 这三个抽象成接口,支持SPI扩展,方便用户自定义扩展存储方式。

Make MetricWriter, MetricReader and MetricsSearcher SPI extension interfaces so that users can implement their own metrics storage.

@sentinel-bot
Copy link
Collaborator

Hi @kangyl, we detect non-English characters in the issue. This comment is an auto translation from @sentinel-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

Can MetricWriter and MetricReader be abstracted into interfaces and support SPI extensions?

Issue Description

MetricWriter, MetricReader, MetricsReader These three abstract interfaces, support SPI extension, convenient user-defined extended storage
Type: bug report or feature request
feature request

Describe what happened (or what feature you want)

none

Describe what you expected to happen

none

How to reproduce it (as minimally and precisely as possible)

none

Tell us your environment

none

Anything else we need to know?

none

@sentinel-bot sentinel-bot changed the title MetricWriter and MetricReader 能否抽象成接口,支持SPI扩展 Can MetricWriter and MetricReader be abstracted into interfaces and support SPI extensions? Jan 28, 2019
@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. area/metrics Issues or PRs related to metrics and monitoring labels Jan 28, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 28, 2019

Hi, we're planning to do this, but the first thing is to diversify and standardize Sentinel metrics and monitoring interfaces (see #211). Discussions are welcomed.

BTW, there's already a PR for this: #167 but it lacks some standardization on metrics interface. You can refer to that PR for more information.

@sczyh30 sczyh30 added kind/feature Category issues or prs related to feature request. and removed kind/enhancement Category issues or prs related to enhancement. labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Issues or PRs related to metrics and monitoring kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

No branches or pull requests

3 participants