Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Diversify and standardize Sentinel metrics and monitoring #211

Open
sczyh30 opened this issue Oct 30, 2018 · 2 comments
Open

[RFC] Diversify and standardize Sentinel metrics and monitoring #211

sczyh30 opened this issue Oct 30, 2018 · 2 comments
Labels
area/metrics Issues or PRs related to metrics and monitoring kind/feature Category issues or prs related to feature request.
Milestone

Comments

@sczyh30
Copy link
Member

sczyh30 commented Oct 30, 2018

Issue Description

Type: feature request

Describe what feature you want

Currently the metrics and monitoring of Sentinel is not standardized and versatile enough. This issue will discuss about standardization and improvements of metrics and monitoring of Sentinel, so that we can enable:

  • provide standard and diverse metrics representation (e.g. percentile, gauge, histogram)
  • standardization of monitoring API and transport server API, and adapt to open-source monitoring components (e.g. Prometheus)
  • integration with open-source visualization solution (e.g. Grafana) in Sentinel Dashboard

Suggestions are welcomed :)

@sczyh30 sczyh30 added the kind/feature Category issues or prs related to feature request. label Oct 30, 2018
@sczyh30 sczyh30 added this to the 1.5.0 milestone Oct 30, 2018
@CarpenterLee
Copy link
Contributor

Sentinel has being tracing every method call in it's context, so the simplest way enhance the metric is to add some callbacks to inform the existing metic implementation, such as Ali-metric or Prometheus.

Since diversifying the metrics is not the main feature of Sentinel(which is flow controlling and shaping), the standard metric feature should be pluggable and replaceable. So we may need anther Sentinel extension to do this work.

@CarpenterLee CarpenterLee changed the title [RFC] Standardization of metrics and monitoring [RFC] Diversify and standardize Sentinel metrics and monitoring Dec 17, 2018
@sczyh30 sczyh30 added the help wanted Extra attention is needed label Jan 22, 2019
@sczyh30 sczyh30 added area/metrics Issues or PRs related to metrics and monitoring and removed help wanted Extra attention is needed labels Jan 28, 2019
@sczyh30 sczyh30 modified the milestones: 1.6.0, 1.7.0 Mar 27, 2019
@sczyh30 sczyh30 removed this from the 1.7.2 milestone Nov 8, 2019
@XiaoWeiKIN
Copy link

hi,what's going on now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Issues or PRs related to metrics and monitoring kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

No branches or pull requests

3 participants