Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data-source extension Spring Cloud Config #831

Closed
hgccode opened this issue Jun 13, 2019 · 12 comments
Closed

Support data-source extension Spring Cloud Config #831

hgccode opened this issue Jun 13, 2019 · 12 comments
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/feature Category issues or prs related to feature request.

Comments

@hgccode
Copy link

hgccode commented Jun 13, 2019

Issue Description

sentinel-datasource suport spring cloud config?
Type: bug report or feature request

Describe what happened (or what feature you want)

Now, main support nacos,zeepkeeper and so on. I want to support spring-cloud-config and eureka. make su

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?

@sczyh30
Copy link
Member

sczyh30 commented Jun 13, 2019

Hi, Sentinel data-source extension does not have Eureka and Spring Cloud Config integration. Would you like to contribute? :)

@sczyh30 sczyh30 changed the title sentinel-datasource suport spring-cloud-config and eureka? Support data-source extension for Eureka and Spring Cloud Config Jun 13, 2019
@sczyh30 sczyh30 added good first issue Good for newcomers kind/feature Category issues or prs related to feature request. labels Jun 13, 2019
@wchswchs
Copy link
Contributor

wchswchs commented Jun 19, 2019

I think I can do it. :)

@sczyh30
Copy link
Member

sczyh30 commented Jun 19, 2019

I think I can do it. :)

Nice! You could refer to existing data source implementations like sentinel-datasource-zookeeper. Looking forward to your PR :)

@wchswchs
Copy link
Contributor

ok

@sczyh30
Copy link
Member

sczyh30 commented Jul 5, 2019

Hi, any progress? :)

@sczyh30 sczyh30 added the area/integrations Issues or PRs related to integrations with open-source components label Jul 5, 2019
@linlinisme
Copy link
Collaborator

linlinisme commented Jul 5, 2019

I have an idea about how to support spring-could-config. It base on Pull mode, by through the org.springframework.cloud.config.client.ConfigServicePropertySourceLocator schedule pull the configuration. The problem solved :)

@wchswchs
Copy link
Contributor

wchswchs commented Jul 5, 2019

I'm so busy on work these days. @linlinisme, if you have time, are you willing to implement this?

@linlinisme
Copy link
Collaborator

@sczyh30 @wchswchs that is my proposal #899, May be you two can give me some good suggestion.

@sczyh30
Copy link
Member

sczyh30 commented Jul 9, 2019

👍 I'll have a look these days.

@sczyh30 sczyh30 changed the title Support data-source extension for Eureka and Spring Cloud Config Support data-source extension Spring Cloud Config Aug 2, 2019
@sczyh30
Copy link
Member

sczyh30 commented Aug 20, 2019

Spring Cloud Config data-source has been supported via #899, which will be released in 1.7.0.

@sczyh30 sczyh30 closed this as completed Aug 20, 2019
@kaori-seasons
Copy link
Contributor

@sczyh30 Hello, I want to contribute dynamic rule source extension support for Eureka

@sczyh30
Copy link
Member

sczyh30 commented Dec 13, 2019

@sczyh30 Hello, I want to contribute dynamic rule source extension support for Eureka

Nice! I've opened a new issue #1197. You could reply in the issue, then contribute a PR for it :)

CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
[RIP-10] Optimize test batch send message use cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components good first issue Good for newcomers kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

No branches or pull requests

5 participants