-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentinel console disable login #1004
Conversation
sentinel-dashboard/src/main/webapp/resources/app/scripts/directives/header/header.js
Outdated
Show resolved
Hide resolved
@zhaoyuguang The CI indicates test failure. Could you please resolve it? |
...ashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/auth/SimpleWebAuthServiceImpl.java
Show resolved
Hide resolved
...el-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/controller/AuthController.java
Outdated
Show resolved
Hide resolved
...el-dashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/controller/AuthController.java
Outdated
Show resolved
Hide resolved
sentinel-dashboard/src/main/webapp/resources/app/scripts/directives/header/header.js
Outdated
Show resolved
Hide resolved
...ashboard/src/main/java/com/alibaba/csp/sentinel/dashboard/auth/SimpleWebAuthServiceImpl.java
Show resolved
Hide resolved
Could you please also execute the |
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
============================================
- Coverage 42.74% 42.68% -0.07%
+ Complexity 1475 1474 -1
============================================
Files 317 317
Lines 9280 9280
Branches 1267 1267
============================================
- Hits 3967 3961 -6
- Misses 4823 4828 +5
- Partials 490 491 +1
Continue to review full report at Codecov.
|
Thanks for the guidance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhaoyuguang Nice work! Thanks for your contribution. I think the implement is simple and clever. |
👍 |
[RIP-9] Polish Operations_Trace.md
Describe what this PR does / why we need it
由于部分公司自己开发了控制台,不希望被Sentinel的安全认证拦截。因此Sentinel支持定制关闭登陆功能,
application.properties auth.enabled=false
即可完成 不需要登录主要改造有两点
1:AuthService的实例化类 改为使用auth.enabled变量控制那个实例初始化
2:增加接口以便与模拟登陆。
Does this pull request fix one issue?
Resolves #997
Describe how you did it
Describe how to verify it
Special notes for reviews