Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentinel console disable login #1004

Merged
merged 13 commits into from
Aug 26, 2019
Merged

Conversation

zhaoyuguang
Copy link
Collaborator

@zhaoyuguang zhaoyuguang commented Aug 21, 2019

Describe what this PR does / why we need it

由于部分公司自己开发了控制台,不希望被Sentinel的安全认证拦截。因此Sentinel支持定制关闭登陆功能,application.properties auth.enabled=false即可完成 不需要登录

主要改造有两点
1:AuthService的实例化类 改为使用auth.enabled变量控制那个实例初始化
2:增加接口以便与模拟登陆。

Does this pull request fix one issue?

Resolves #997

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added area/dashboard Issues or PRs about Sentinel Dashboard to-review To review labels Aug 21, 2019
@sczyh30 sczyh30 requested a review from cdfive August 21, 2019 07:40
@sczyh30
Copy link
Member

sczyh30 commented Aug 21, 2019

@zhaoyuguang The CI indicates test failure. Could you please resolve it?

@sczyh30
Copy link
Member

sczyh30 commented Aug 25, 2019

Could you please also execute the npm run build for the frontend and update the file dist/js/app.js?

@codecov-io
Copy link

Codecov Report

Merging #1004 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1004      +/-   ##
============================================
- Coverage     42.74%   42.68%   -0.07%     
+ Complexity     1475     1474       -1     
============================================
  Files           317      317              
  Lines          9280     9280              
  Branches       1267     1267              
============================================
- Hits           3967     3961       -6     
- Misses         4823     4828       +5     
- Partials        490      491       +1
Impacted Files Coverage Δ Complexity Δ
...p/sentinel/datasource/consul/ConsulDataSource.java 63.76% <0%> (-5.8%) 7% <0%> (ø)
...tinel/slots/block/flow/param/ParamFlowChecker.java 52.7% <0%> (-2.71%) 28% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 72.27% <0%> (+1.98%) 35% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976ddf8...f9166af. Read the comment docs.

@zhaoyuguang
Copy link
Collaborator Author

zhaoyuguang commented Aug 26, 2019

Could you please also execute the npm run build for the frontend and update the file dist/js/app.js?

Thanks for the guidance,app.js has been added and CI look run normal

Copy link
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdfive cdfive merged commit 820ff92 into alibaba:master Aug 26, 2019
@cdfive
Copy link
Collaborator

cdfive commented Aug 26, 2019

@zhaoyuguang Nice work! Thanks for your contribution. I think the implement is simple and clever.

@sczyh30 sczyh30 removed the to-review To review label Aug 26, 2019
@sczyh30 sczyh30 added this to the 1.7.0 milestone Aug 26, 2019
@sczyh30
Copy link
Member

sczyh30 commented Aug 26, 2019

👍

CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
[RIP-9] Polish Operations_Trace.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can sentinel console disable login?
4 participants